Рефакторинг + DI

This commit is contained in:
Danil Kislov
2019-03-15 17:49:58 +03:00
parent fd02201b42
commit d56094febb
19 changed files with 288 additions and 105 deletions
+5 -20
View File
@@ -9,13 +9,15 @@ using Mercurial;
namespace JiraTimeBotForm.Mercurial
{
public class MercurialLog
public class MercurialLog: IMercurialLog
{
private readonly ILog _log;
private readonly ICommitSkipper _commitSkipper;
public MercurialLog(ILog log)
public MercurialLog(ILog log, ICommitSkipper commitSkipper)
{
_log = log;
_commitSkipper = commitSkipper;
}
public List<MercurialCommitItem> GetMercurialLog(Settings settings, DateTime? date = null, CancellationToken cancellationToken = default(CancellationToken))
@@ -54,7 +56,7 @@ namespace JiraTimeBotForm.Mercurial
}
var commitMessage = FixEncoding(changeset.CommitMessage);
if (IsNeedToSkip(changeset.Branch, commitMessage))
if (_commitSkipper.IsNeedToSkip(changeset.Branch, commitMessage))
{
continue;
}
@@ -113,23 +115,6 @@ namespace JiraTimeBotForm.Mercurial
return message;
}
private bool IsNeedToSkip(string branch, string commitMessage)
{
if (!branch.Contains("-"))
{
return true;
}
//Пропускаем Close и Merge коммиты
if (commitMessage.StartsWith($"Close {branch} ", StringComparison.InvariantCultureIgnoreCase) ||
commitMessage.StartsWith($"Merge with ", StringComparison.InvariantCultureIgnoreCase))
{
return true;
}
return false;
}
private string FixEncoding(string source)
{
//перекодируем сообщение - ибо оно криво забирается в 1252