Исправление алгоритма удаления ворклогов

.semver.txt

@@ -1 +1 @@
-1.0.19
+1.0.22

README.md

@@ -1,7 +1,9 @@
 # JiraTimeBot [![Build Status](https://travis-ci.org/monster1025/JiraTimeBot.svg?branch=master)](https://travis-ci.org/monster1025/JiraTimeBot)
 Приложение для автоматического добавления Jira Worklog'ов исходя из количества коммитов в ветку.
 
-# Предположения
+# Ограничения
  - Предполагается что все Ваши репозитории находятся в одной папке (к которой вы указываете путь в настройках).
  - Предполагается что ветки в JIRA имеют название эквивалентное имени бранча в Mercurial.
 
+# Скачать
+Скачать актуальную версию можно тут: https://github.com/monster1025/JiraTimeBot/releases/latest

release.cmd

@@ -19,7 +19,7 @@ call tools\SetVersion.cmd %VERSION%
 git add .
 git commit -m "%~1"
 
-git tag -m "Version v%VERSION%" -a v%VERSION%
+git tag -m "Version v%VERSION%: %~1" -a v%VERSION%
 git push origin v%VERSION%
 
 git push

src/JiraTimeBot/DI/ContainerBuilder.cs

@@ -1,5 +1,4 @@
-using System.Windows.Forms;
+using Autofac;
-using Autofac;
 using Autofac.Extras.AggregateService;
 using JiraTimeBot.JiraIntegration;
 using JiraTimeBot.JiraIntegration.Comments;
@@ -8,6 +7,8 @@ using JiraTimeBot.Mercurial.Modifiers;
 using JiraTimeBot.TasksProcessors;
 using JiraTimeBot.TaskTime;
 using JiraTimeBot.UI.Tray;
+using System;
+using System.Windows.Forms;
 
 namespace JiraTimeBot.DI
 {
@@ -21,8 +22,17 @@ namespace JiraTimeBot.DI
 
         public IContainer Build(TextBox logTextBox)
         {
-            _builder.Register(f => new Logger(logTextBox)).As<ILog>().AsSelf();
+            _builder.Register(c => logTextBox).AsSelf();
-            
+
+            _builder.Register(f =>
+            {
+                var txt = f.Resolve<TextBox>();
+                return new Logger(message =>
+                {
+                    txt.Invoke(new Action<string>(text => txt.AppendText(text)), message + Environment.NewLine);
+                });
+            }).As<ILog>().AsSelf();
+
             _builder.Register(f => new TrayMenu()).As<ITrayMenu>().AsSelf();
             _builder.Register(c => new CommitSkipper()).As<ICommitSkipper>();
 

src/JiraTimeBot/JiraIntegration/Comments/JiraDescriptionSource.cs

@@ -1,8 +1,8 @@
-using System;
+using JiraTimeBot.Configuration;
+using JiraTimeBot.TaskTime.Objects;
+using System;
 using System.Collections.Generic;
 using System.Linq;
-using JiraTimeBot.Configuration;
-using JiraTimeBot.TaskTime.Objects;
 
 namespace JiraTimeBot.JiraIntegration.Comments
 {

src/JiraTimeBot/JiraIntegration/JiraApi.cs

@@ -92,26 +92,34 @@ namespace JiraTimeBot.JiraIntegration
 
                 var hasTodayWorklog = false;
                 var workLogs = issue.GetWorklogsAsync().Result;
-                foreach (var workLog in workLogs)
+                var userWorklogs = workLogs.Where(w =>
+                    w.CreateDate.GetValueOrDefault().Date == date && w.Author.Equals(settings.JiraUserName,
+                        StringComparison.InvariantCultureIgnoreCase)).ToList();
+
+                foreach (var workLog in userWorklogs)
                 {
                     var timeSpent = TimeSpan.FromSeconds(workLog.TimeSpentInSeconds);
-                    if (workLog.CreateDate.GetValueOrDefault().Date == date && workLog.Author == settings.JiraUserName)
+                    var timeDiff = Math.Abs((timeSpent - taskTimeItem.Time).TotalMinutes);
+                    if (timeDiff > 1 || userWorklogs.Count > 1)
                     {
-                        var timeDiff = Math.Abs((timeSpent - taskTimeItem.Time).TotalMinutes);
                         if (timeDiff > 1)
                         {
                             _log.Trace($"Время отличается на {timeDiff} минут, удаляю worklog: {taskTimeItem.Branch} {workLog.Author} {workLog.CreateDate}: {workLog.TimeSpent}");
-                            if (!dummy)
-                            {
-                                issue.DeleteWorklogAsync(workLog);
-                            }
-                            hasTodayWorklog = false;
                         }
                         else
                         {
-                            _log.Trace($"По задаче {taskTimeItem.Branch} уже есть аналогичный worklog. Пропускаю.");
+                            _log.Trace($"Найдено более одного ворклога на задачу, удаляю worklog: {taskTimeItem.Branch} {workLog.Author} {workLog.CreateDate}: {workLog.TimeSpent}");
-                            hasTodayWorklog = true;
                         }
+                        if (!dummy)
+                        {
+                            issue.DeleteWorklogAsync(workLog);
+                        }
+                        hasTodayWorklog = false;
+                    }
+                    else
+                    {
+                        _log.Trace($"По задаче {taskTimeItem.Branch} уже есть аналогичный worklog. Пропускаю.");
+                        hasTodayWorklog = true;
                     }
                 }
 

src/JiraTimeBot/Logger.cs

@@ -1,29 +1,23 @@
 using System;
 using System.ComponentModel;
-using System.Windows.Forms;
 
 namespace JiraTimeBot
 {
     public class Logger : ILog
     {
-        private readonly TextBox _txt;
+        private readonly Action<string> _logAction;
-        private readonly AppendLog _safeAppender;
 
-        public Logger(TextBox txt)
+        public Logger(Action<string> logAction)
         {
-            _txt = txt;
+            _logAction = logAction;
-            _safeAppender = text => _txt.AppendText(text);
-
         }
 
         private void AppendText(string message)
         {
             message = $"{DateTime.Now:HH:mm} {message}";
-            _txt.Invoke(_safeAppender, message + Environment.NewLine);
+            _logAction(message);
         }
 
-        private delegate void AppendLog(string text);
-
         public void Info([Localizable(false)] string message)
         {
             AppendText(message);

src/JiraTimeBot/Program.cs

@@ -1,45 +1,30 @@
-using System;
+using JiraTimeBot.UI;
-using System.Diagnostics;
+using System;
+using System.Threading;
 using System.Windows.Forms;
-using JiraTimeBot.UI;
 
 namespace JiraTimeBot
 {
     static class Program
     {
+        private static Mutex _mutex = new Mutex(true, "{44426B3E-B901-4792-ACEA-1385D79DBAD1}");
         /// <summary>
         /// The main entry point for the application.
         /// </summary>
         [STAThread]
         static void Main()
         {
-            if (PriorProcess() != null)
+            if (_mutex.WaitOne(TimeSpan.Zero, true))
+            {
+                Application.EnableVisualStyles();
+                Application.SetCompatibleTextRenderingDefault(false);
+                Application.Run(new frmMain());
+                _mutex.ReleaseMutex();
+            }
+            else
             {
-
                 MessageBox.Show("Another instance of the app is already running.");
-                return;
             }
-            
-            Application.EnableVisualStyles();
-            Application.SetCompatibleTextRenderingDefault(false);
-            Application.Run(new frmMain());
-        }
-
-        public static Process PriorProcess()
-            // Returns a System.Diagnostics.Process pointing to
-            // a pre-existing process with the same name as the
-            // current one, if any; or null if the current process
-            // is unique.
-        {
-            Process curr = Process.GetCurrentProcess();
-            Process[] procs = Process.GetProcessesByName(curr.ProcessName);
-            foreach (Process p in procs)
-            {
-                if ((p.Id != curr.Id) &&
-                    (p.MainModule.FileName == curr.MainModule.FileName))
-                    return p;
-            }
-            return null;
         }
     }
 }

src/JiraTimeBot/Properties/AssemblyInfo.cs

@@ -1,31 +1,31 @@
-using System.Reflection;          
+using System.Reflection;             
-using System.Runtime.InteropServices;          
+using System.Runtime.InteropServices;             
-// General Information about an assembly is controlled through the following          
+// General Information about an assembly is controlled through the following             
-// set of attributes. Change these attribute values to modify the information          
+// set of attributes. Change these attribute values to modify the information             
-// associated with an assembly.          
+// associated with an assembly.             
-[assembly: AssemblyTitle("JiraTimeBot")]          
+[assembly: AssemblyTitle("JiraTimeBot")]             
-[assembly: AssemblyDescription("")]          
+[assembly: AssemblyDescription("")]             
-[assembly: AssemblyConfiguration("")]          
+[assembly: AssemblyConfiguration("")]             
-[assembly: AssemblyCompany("")]          
+[assembly: AssemblyCompany("")]             
-[assembly: AssemblyProduct("JiraTimeBot")]          
+[assembly: AssemblyProduct("JiraTimeBot")]             
-[assembly: AssemblyCopyright("Copyright © 2019")]          
+[assembly: AssemblyCopyright("Copyright © 2019")]             
-[assembly: AssemblyTrademark("")]          
+[assembly: AssemblyTrademark("")]             
-[assembly: AssemblyCulture("")]          
+[assembly: AssemblyCulture("")]             
-// Setting ComVisible to false makes the types in this assembly not visible          
+// Setting ComVisible to false makes the types in this assembly not visible             
-// to COM components.  If you need to access a type in this assembly from          
+// to COM components.  If you need to access a type in this assembly from             
-// COM, set the ComVisible attribute to true on that type.          
+// COM, set the ComVisible attribute to true on that type.             
-[assembly: ComVisible(false)]          
+[assembly: ComVisible(false)]             
-// The following GUID is for the ID of the typelib if this project is exposed to COM          
+// The following GUID is for the ID of the typelib if this project is exposed to COM             
-[assembly: Guid("f3b89316-c38c-4ce6-9d88-0b1373cfba1a")]          
+[assembly: Guid("f3b89316-c38c-4ce6-9d88-0b1373cfba1a")]             
-// Version information for an assembly consists of the following four values:          
+// Version information for an assembly consists of the following four values:             
-//          
+//             
-//      Major Version          
+//      Major Version             
-//      Minor Version          
+//      Minor Version             
-//      Build Number          
+//      Build Number             
-//      Revision          
+//      Revision             
-//          
+//             
-// You can specify all the values or you can default the Build and Revision Numbers          
+// You can specify all the values or you can default the Build and Revision Numbers             
-// by using the '*' as shown below:          
+// by using the '*' as shown below:             
-[assembly: AssemblyVersion("1.0.19")] 
+[assembly: AssemblyVersion("1.0.22")] 
-[assembly: AssemblyFileVersion("1.0.19")] 
+[assembly: AssemblyFileVersion("1.0.22")] 
-[assembly: AssemblyInformationalVersion("1.0.19")] 
+[assembly: AssemblyInformationalVersion("1.0.22")] 

src/JiraTimeBot/TaskTime/TaskTimeByCommitsCalculator.cs

@@ -23,6 +23,17 @@ namespace JiraTimeBot.TaskTime
             int remainMinutes = settings.MinuterPerWorkDay;
             int totalCommitsCount = commits.Count;
 
+            //если кол-во коммитов более чем кол-во интервалов - то уменьшим интервал вдвое.
+            while (totalCommitsCount > (8 * (60.0 / settings.RountToMinutes)))
+            {
+                settings.RountToMinutes = (int)RoundTo((decimal)(settings.RountToMinutes / 2.0), 5);
+                _log.Info($"Слишком много задачь - уменьшаю интервал до {settings.RountToMinutes}.");
+                if (settings.RountToMinutes == 5)
+                {
+                    break;
+                }
+            }
+
             List<TaskTimeItem> workTimeItems = new List<TaskTimeItem>();
 
             //Нам нужно раскидать 480 минут в день.
@@ -67,8 +78,11 @@ namespace JiraTimeBot.TaskTime
                 _log.Trace($"Погрешность распределения времени: {remainMinutes}. Добавляю к первой задаче.");
             }
 
-            //если переборщили или не достаточно добавили до 8 часов - скореектируем остаток в первой задаче (она самая трудозатратная).
+            if (workTimeItems.First().Time.TotalMinutes > Math.Abs(remainMinutes) && remainMinutes < 0)
-            workTimeItems.First().Time += TimeSpan.FromMinutes(remainMinutes);
+            {
+                //если переборщили или не достаточно добавили до 8 часов - скореектируем остаток в первой задаче (она самая трудозатратная).
+                workTimeItems.First().Time += TimeSpan.FromMinutes(remainMinutes);
+            }
 
             return workTimeItems;
         }

src/JiraTimeBot/UI/frmMain.Designer.cs

@@ -114,7 +114,7 @@
             // 
             // tmrUpdate
             // 
-            this.tmrUpdate.Interval = 10000;
+            this.tmrUpdate.Interval = 1000;
             this.tmrUpdate.Tick += new System.EventHandler(this.tmrUpdate_Tick);
             // 
             // frmMain

src/JiraTimeBot/UI/frmMain.cs

@@ -1,16 +1,16 @@
-using System;
+using Autofac;
+using JiraTimeBot.Configuration;
+using JiraTimeBot.DI;
+using JiraTimeBot.TasksProcessors;
+using JiraTimeBot.UI.Tray;
+using JiraTimeBot.Update;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.IO.Compression;
 using System.Threading;
 using System.Threading.Tasks;
 using System.Windows.Forms;
-using Autofac;
-using JiraTimeBot.Configuration;
-using JiraTimeBot.DI;
-using JiraTimeBot.TasksProcessors;
-using JiraTimeBot.UI.Tray;
-using JiraTimeBot.Update;
 
 // This is the code for your desktop app.
 // Press Ctrl+F5 (or go to Debug > Start Without Debugging) to run your app.