Рефакторинг имени клода
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
using System;
|
||||
using System.Threading.Tasks;
|
||||
using MonsterMonitor.Models;
|
||||
|
||||
namespace MonsterMonitor.Services
|
||||
@@ -26,12 +27,14 @@ namespace MonsterMonitor.Services
|
||||
_power.PreventSleep();
|
||||
_processMonitor = new ProcessMonitorService(_log);
|
||||
_sshTunnel = new SshTunnelService(_log);
|
||||
_authMonitor = new AuthMonitor(settings);
|
||||
_authMonitor = new AuthMonitor(settings, _log);
|
||||
|
||||
_ssConfig.EnsureConfig(settings);
|
||||
_processMonitor.Start(settings.SsProcessPath, settings.SsArguments);
|
||||
_sshTunnel.Start(settings);
|
||||
_ = _authMonitor.StartMonitor();
|
||||
_authMonitor.StartMonitor().ContinueWith(
|
||||
t => _log.Error("Ошибка запуска монитора авторизации: " + t.Exception?.GetBaseException().Message),
|
||||
TaskContinuationOptions.OnlyOnFaulted);
|
||||
|
||||
_log.Info("Сервисы приложения запущены.");
|
||||
}
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
using System;
|
||||
using System.Diagnostics;
|
||||
using System;
|
||||
using System.Runtime.InteropServices;
|
||||
using System.Text;
|
||||
using System.Threading;
|
||||
@@ -9,32 +8,81 @@ using MonsterMonitor.Models;
|
||||
|
||||
namespace MonsterMonitor.Services
|
||||
{
|
||||
public class AuthMonitor: IAuthMonitor
|
||||
public class AuthMonitor : IAuthMonitor
|
||||
{
|
||||
private const string AuthWindowMarker = "XAuth request";
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
static extern IntPtr GetForegroundWindow();
|
||||
private static extern IntPtr GetForegroundWindow();
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
private static extern bool SetForegroundWindow(IntPtr hWnd);
|
||||
|
||||
[DllImport("user32.dll", CharSet = CharSet.Auto)]
|
||||
private static extern int GetWindowText(IntPtr hWnd, StringBuilder text, int count);
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
static extern int GetWindowText(IntPtr hWnd, StringBuilder text, int count);
|
||||
private static extern int GetWindowTextLength(IntPtr hWnd);
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
private static extern bool IsWindowVisible(IntPtr hWnd);
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
private static extern bool EnumWindows(EnumWindowsProc lpEnumFunc, IntPtr lParam);
|
||||
|
||||
private delegate bool EnumWindowsProc(IntPtr hWnd, IntPtr lParam);
|
||||
|
||||
private readonly AppSettings _settings;
|
||||
private readonly LogService _log;
|
||||
private CancellationTokenSource _monitorCancellation;
|
||||
private Task _monitorTask;
|
||||
|
||||
public AuthMonitor(AppSettings settings)
|
||||
public AuthMonitor(AppSettings settings, LogService log)
|
||||
{
|
||||
_settings = settings;
|
||||
_log = log;
|
||||
}
|
||||
|
||||
private string GetActiveWindowTitle()
|
||||
private static string GetWindowTitle(IntPtr handle)
|
||||
{
|
||||
const int nChars = 256;
|
||||
var buff = new StringBuilder(nChars);
|
||||
var handle = GetForegroundWindow();
|
||||
return GetWindowText(handle, buff, nChars) > 0 ? buff.ToString() : null;
|
||||
var length = GetWindowTextLength(handle);
|
||||
if (length <= 0)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var buff = new StringBuilder(length + 1);
|
||||
return GetWindowText(handle, buff, buff.Capacity) > 0 ? buff.ToString() : null;
|
||||
}
|
||||
|
||||
private static string GetActiveWindowTitle()
|
||||
{
|
||||
return GetWindowTitle(GetForegroundWindow());
|
||||
}
|
||||
|
||||
// Ищет окно авторизации через перечисление окон (без перебора всех процессов
|
||||
// и без утечки хендлов Process). Возвращает первое видимое подходящее окно.
|
||||
private static IntPtr FindAuthWindow()
|
||||
{
|
||||
var found = IntPtr.Zero;
|
||||
EnumWindows((hWnd, lParam) =>
|
||||
{
|
||||
if (!IsWindowVisible(hWnd))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
var title = GetWindowTitle(hWnd);
|
||||
if (title != null && title.IndexOf(AuthWindowMarker, StringComparison.OrdinalIgnoreCase) >= 0)
|
||||
{
|
||||
found = hWnd;
|
||||
return false; // прекращаем перечисление
|
||||
}
|
||||
|
||||
return true;
|
||||
}, IntPtr.Zero);
|
||||
|
||||
return found;
|
||||
}
|
||||
|
||||
public async Task StartMonitor()
|
||||
@@ -75,29 +123,28 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
try
|
||||
{
|
||||
Process[] processlist = Process.GetProcesses();
|
||||
foreach (Process process in processlist)
|
||||
var authWindow = FindAuthWindow();
|
||||
if (authWindow != IntPtr.Zero)
|
||||
{
|
||||
if (!string.IsNullOrEmpty(process.MainWindowTitle) && process.MainWindowTitle.Contains("XAuth request"))
|
||||
{
|
||||
SetForegroundWindow(process.MainWindowHandle);
|
||||
}
|
||||
}
|
||||
SetForegroundWindow(authWindow);
|
||||
|
||||
var activeWindowTitle = GetActiveWindowTitle();
|
||||
if (activeWindowTitle?.Contains("XAuth request") == true)
|
||||
{
|
||||
var password = _settings.GetSystemPassword();
|
||||
if (!string.IsNullOrEmpty(password))
|
||||
var activeWindowTitle = GetActiveWindowTitle();
|
||||
if (activeWindowTitle?.IndexOf(AuthWindowMarker, StringComparison.OrdinalIgnoreCase) >= 0)
|
||||
{
|
||||
SendKeys.SendWait(password);
|
||||
SendKeys.SendWait("{ENTER}");
|
||||
var password = _settings.GetSystemPassword();
|
||||
if (!string.IsNullOrEmpty(password))
|
||||
{
|
||||
SendKeys.SendWait(password);
|
||||
SendKeys.SendWait("{ENTER}");
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
MessageBox.Show(ex.Message + ex.StackTrace);
|
||||
// Раньше здесь был MessageBox.Show из фонового потока — при повторяющемся
|
||||
// исключении он заваливал рабочий стол окнами. Теперь просто пишем в лог.
|
||||
_log.Warn("Ошибка мониторинга авторизации: " + ex.Message);
|
||||
}
|
||||
|
||||
try
|
||||
|
||||
@@ -13,6 +13,7 @@ namespace MonsterMonitor.Services
|
||||
private string _path;
|
||||
private string _arguments;
|
||||
private bool _stopping;
|
||||
private string _lastStartError;
|
||||
|
||||
public ProcessMonitorService(LogService log)
|
||||
{
|
||||
@@ -43,7 +44,6 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
if (_process != null)
|
||||
{
|
||||
_process.Exited -= ProcessOnExited;
|
||||
_process.Dispose();
|
||||
}
|
||||
_process = new Process
|
||||
@@ -57,27 +57,19 @@ namespace MonsterMonitor.Services
|
||||
},
|
||||
EnableRaisingEvents = true
|
||||
};
|
||||
//_process.Exited += ProcessOnExited;
|
||||
_process.Start();
|
||||
_lastStartError = null;
|
||||
_log.Info("Процесс ss запущен.");
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_log.Error("Ошибка запуска ss: " + ex.Message);
|
||||
}
|
||||
}
|
||||
|
||||
private void ProcessOnExited(object sender, EventArgs e)
|
||||
{
|
||||
lock (_sync)
|
||||
{
|
||||
if (_stopping)
|
||||
// Watchdog тикает каждые 10с; при неверном пути не флудим лог
|
||||
// одинаковой ошибкой — пишем её только при изменении.
|
||||
if (_lastStartError != ex.Message)
|
||||
{
|
||||
return;
|
||||
_lastStartError = ex.Message;
|
||||
_log.Error("Ошибка запуска ss: " + ex.Message);
|
||||
}
|
||||
|
||||
_log.Warn("Процесс ss завершился, запускаю заново.");
|
||||
EnsureStarted();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -118,7 +110,6 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
if (_process != null)
|
||||
{
|
||||
_process.Exited -= ProcessOnExited;
|
||||
_process.Dispose();
|
||||
}
|
||||
_process = null;
|
||||
|
||||
@@ -12,16 +12,21 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
private readonly LogService _log;
|
||||
private readonly object _sync = new object();
|
||||
|
||||
// Сериализует реконнект: перекрывающиеся запросы (из событий и из монитора)
|
||||
// отбрасываются, а не выполняются параллельно и не копятся в очередь.
|
||||
private readonly SemaphoreSlim _reconnectGate = new SemaphoreSlim(1, 1);
|
||||
|
||||
private SshClient _client;
|
||||
private ForwardedPortRemote _forwardedPort;
|
||||
private SshCommand _heartbeatCommand;
|
||||
private CancellationTokenSource _heartbeatReadTokenSource;
|
||||
private Task _heartbeatReadTask;
|
||||
private CancellationTokenSource _monitorTokenSource;
|
||||
private Task _monitorTask;
|
||||
private AppSettings _settings;
|
||||
private bool _disposed;
|
||||
private bool _reconnectInProgress;
|
||||
private DateTime _lastHeartbeatUtc = DateTime.MinValue;
|
||||
private volatile bool _disposed;
|
||||
private long _lastHeartbeatTicks;
|
||||
private bool _remoteIsWindows;
|
||||
|
||||
public SshTunnelService(LogService log)
|
||||
@@ -55,6 +60,10 @@ namespace MonsterMonitor.Services
|
||||
var authMethod = new PasswordAuthenticationMethod(_settings.SshUsername, password);
|
||||
var connectionInfo = new ConnectionInfo(_settings.SshHost, _settings.SshPort, _settings.SshUsername, authMethod);
|
||||
|
||||
// Ограничиваем блокирующий Connect(), чтобы он не висел бесконечно.
|
||||
var timeoutSec = Math.Min(60, Math.Max(5, _settings.ReconnectTimeoutSec));
|
||||
connectionInfo.Timeout = TimeSpan.FromSeconds(timeoutSec);
|
||||
|
||||
_client = new SshClient(connectionInfo);
|
||||
_client.ErrorOccurred += ClientOnErrorOccurred;
|
||||
_client.Connect();
|
||||
@@ -85,7 +94,7 @@ namespace MonsterMonitor.Services
|
||||
private void StartMonitor()
|
||||
{
|
||||
_monitorTokenSource = new CancellationTokenSource();
|
||||
Task.Run(() => MonitorLoop(_monitorTokenSource.Token));
|
||||
_monitorTask = Task.Run(() => MonitorLoop(_monitorTokenSource.Token));
|
||||
}
|
||||
|
||||
private async Task MonitorLoop(CancellationToken token)
|
||||
@@ -94,18 +103,23 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
try
|
||||
{
|
||||
var silenceThresholdSec = Math.Max(
|
||||
5,
|
||||
_settings.MaxPingFailures);
|
||||
|
||||
var lastHeartbeat = _lastHeartbeatUtc;
|
||||
var isHeartbeatAlive = lastHeartbeat != DateTime.MinValue &&
|
||||
(DateTime.UtcNow - lastHeartbeat).TotalSeconds <= silenceThresholdSec;
|
||||
|
||||
if (!IsConnected() || !isHeartbeatAlive)
|
||||
// Пропускаем проверку, пока идёт реконнект — иначе получаем лог-флуд
|
||||
// и лишние пробуждения, дёргающие уже занятый шлюз реконнекта.
|
||||
if (_reconnectGate.CurrentCount > 0)
|
||||
{
|
||||
_log.Warn("Нет живого вывода heartbeat-команды на удаленном сервере. Переподключаю SSH.");
|
||||
await Reconnect().ConfigureAwait(false);
|
||||
// heartbeat присылается раз в секунду; MaxPingFailures трактуем
|
||||
// как допустимое число пропущенных ответов (≈ секунд тишины).
|
||||
var silenceThresholdSec = Math.Max(10, _settings.MaxPingFailures);
|
||||
|
||||
var lastHeartbeatTicks = Interlocked.Read(ref _lastHeartbeatTicks);
|
||||
var isHeartbeatAlive = lastHeartbeatTicks != 0 &&
|
||||
(DateTime.UtcNow - new DateTime(lastHeartbeatTicks, DateTimeKind.Utc)).TotalSeconds <= silenceThresholdSec;
|
||||
|
||||
if (!IsConnected() || !isHeartbeatAlive)
|
||||
{
|
||||
_log.Warn("Нет живого вывода heartbeat-команды на удаленном сервере. Переподключаю SSH.");
|
||||
await Reconnect().ConfigureAwait(false);
|
||||
}
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
@@ -115,9 +129,9 @@ namespace MonsterMonitor.Services
|
||||
|
||||
try
|
||||
{
|
||||
await Task.Delay(TimeSpan.FromSeconds(2), token).ConfigureAwait(false);
|
||||
await Task.Delay(TimeSpan.FromSeconds(3), token).ConfigureAwait(false);
|
||||
}
|
||||
catch (TaskCanceledException)
|
||||
catch (OperationCanceledException)
|
||||
{
|
||||
break;
|
||||
}
|
||||
@@ -136,39 +150,51 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
Task.Run(async () =>
|
||||
{
|
||||
await Task.Delay(1000).ConfigureAwait(false);
|
||||
await Reconnect().ConfigureAwait(false);
|
||||
try
|
||||
{
|
||||
await Task.Delay(1000).ConfigureAwait(false);
|
||||
await Reconnect().ConfigureAwait(false);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
// fire-and-forget: гарантированно не роняем процесс необработанным исключением.
|
||||
_log.Warn("Ошибка отложенного переподключения SSH: " + ex.Message);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private async Task Reconnect()
|
||||
{
|
||||
if (_reconnectInProgress || _disposed)
|
||||
if (_disposed)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// Неблокирующая попытка захватить шлюз: если реконнект уже идёт — выходим,
|
||||
// не создавая второй параллельный Connect() и не накапливая очередь.
|
||||
if (!await _reconnectGate.WaitAsync(0).ConfigureAwait(false))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
_reconnectInProgress = true;
|
||||
try
|
||||
{
|
||||
var timeout = Math.Min(60, Math.Max(5, _settings.ReconnectTimeoutSec));
|
||||
if (_disposed)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
_log.Warn("Перезапуск SSH-соединения...");
|
||||
|
||||
var reconnectTask = Task.Run(() =>
|
||||
// Connect() ограничен ConnectionInfo.Timeout, поэтому не зависнет навсегда.
|
||||
// Ждём завершения задачи (без брошенного WhenAny) — нет орфанных SshClient.
|
||||
await Task.Run(() =>
|
||||
{
|
||||
DisconnectCore();
|
||||
Connect();
|
||||
});
|
||||
}).ConfigureAwait(false);
|
||||
|
||||
var completed = await Task.WhenAny(reconnectTask, Task.Delay(TimeSpan.FromSeconds(timeout))).ConfigureAwait(false);
|
||||
if (completed != reconnectTask)
|
||||
{
|
||||
_log.Error("Переподключение превысило таймаут " + timeout + "с.");
|
||||
}
|
||||
else
|
||||
{
|
||||
_log.Info("SSH-соединение восстановлено.");
|
||||
}
|
||||
_log.Info("SSH-соединение восстановлено.");
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -176,46 +202,51 @@ namespace MonsterMonitor.Services
|
||||
}
|
||||
finally
|
||||
{
|
||||
_reconnectInProgress = false;
|
||||
_reconnectGate.Release();
|
||||
}
|
||||
}
|
||||
|
||||
private void DisconnectCore()
|
||||
{
|
||||
StopRemoteHeartbeatNoLock();
|
||||
lock (_sync)
|
||||
{
|
||||
StopRemoteHeartbeatNoLock();
|
||||
|
||||
try
|
||||
{
|
||||
if (_forwardedPort != null)
|
||||
try
|
||||
{
|
||||
if (_forwardedPort.IsStarted)
|
||||
if (_forwardedPort != null)
|
||||
{
|
||||
_forwardedPort.Stop();
|
||||
if (_forwardedPort.IsStarted)
|
||||
{
|
||||
_forwardedPort.Stop();
|
||||
}
|
||||
_forwardedPort.Exception -= ForwardedPortOnException;
|
||||
_forwardedPort.Dispose();
|
||||
_forwardedPort = null;
|
||||
}
|
||||
_forwardedPort.Dispose();
|
||||
_forwardedPort = null;
|
||||
}
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Ignore errors on shutdown.
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Ignore errors on shutdown.
|
||||
}
|
||||
|
||||
try
|
||||
{
|
||||
if (_client != null)
|
||||
try
|
||||
{
|
||||
if (_client.IsConnected)
|
||||
if (_client != null)
|
||||
{
|
||||
_client.Disconnect();
|
||||
_client.ErrorOccurred -= ClientOnErrorOccurred;
|
||||
if (_client.IsConnected)
|
||||
{
|
||||
_client.Disconnect();
|
||||
}
|
||||
_client.Dispose();
|
||||
_client = null;
|
||||
}
|
||||
_client.Dispose();
|
||||
_client = null;
|
||||
}
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Ignore errors on shutdown.
|
||||
catch
|
||||
{
|
||||
// Ignore errors on shutdown.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -235,7 +266,7 @@ namespace MonsterMonitor.Services
|
||||
|
||||
_heartbeatCommand = _client.CreateCommand(heartbeatCommand);
|
||||
_heartbeatReadTokenSource = new CancellationTokenSource();
|
||||
_lastHeartbeatUtc = DateTime.UtcNow;
|
||||
Interlocked.Exchange(ref _lastHeartbeatTicks, DateTime.UtcNow.Ticks);
|
||||
_heartbeatCommand.BeginExecute();
|
||||
|
||||
_heartbeatReadTask = Task.Run(() =>
|
||||
@@ -287,7 +318,7 @@ namespace MonsterMonitor.Services
|
||||
continue;
|
||||
}
|
||||
|
||||
_lastHeartbeatUtc = DateTime.UtcNow;
|
||||
Interlocked.Exchange(ref _lastHeartbeatTicks, DateTime.UtcNow.Ticks);
|
||||
_log.Debug("HB: " + line);
|
||||
}
|
||||
}
|
||||
@@ -305,9 +336,11 @@ namespace MonsterMonitor.Services
|
||||
{
|
||||
try
|
||||
{
|
||||
var command = _client.CreateCommand("cmd /c ver");
|
||||
var output = command.Execute() ?? string.Empty;
|
||||
return output.IndexOf("windows", StringComparison.OrdinalIgnoreCase) >= 0;
|
||||
using (var command = _client.CreateCommand("cmd /c ver"))
|
||||
{
|
||||
var output = command.Execute() ?? string.Empty;
|
||||
return output.IndexOf("windows", StringComparison.OrdinalIgnoreCase) >= 0;
|
||||
}
|
||||
}
|
||||
catch
|
||||
{
|
||||
@@ -317,19 +350,35 @@ namespace MonsterMonitor.Services
|
||||
|
||||
public void Stop()
|
||||
{
|
||||
_monitorTokenSource?.Cancel();
|
||||
_monitorTokenSource?.Dispose();
|
||||
var monitorTokenSource = _monitorTokenSource;
|
||||
var monitorTask = _monitorTask;
|
||||
_monitorTokenSource = null;
|
||||
lock (_sync)
|
||||
_monitorTask = null;
|
||||
|
||||
try
|
||||
{
|
||||
DisconnectCore();
|
||||
monitorTokenSource?.Cancel();
|
||||
// Дожидаемся завершения цикла монитора до освобождения CTS,
|
||||
// иначе Task.Delay(token) может словить ObjectDisposedException.
|
||||
monitorTask?.Wait(TimeSpan.FromSeconds(2));
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Ignore shutdown errors.
|
||||
}
|
||||
finally
|
||||
{
|
||||
monitorTokenSource?.Dispose();
|
||||
}
|
||||
|
||||
DisconnectCore();
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
_disposed = true;
|
||||
Stop();
|
||||
_reconnectGate.Dispose();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user