Compare commits

...
7 Commits
Author SHA1 Message Date
kislovdm 7db3401799 Рефакторинг имени клода
.NET Core Desktop / build (Debug) (push) Has been cancelled
2026-07-17 13:53:17 +03:00
kislovdm 2da1eac443 Рефакторинг имени клода 2026-07-17 13:50:22 +03:00
kislovdm dc92c80b43 Исправлена нагрузка на проц
.NET Core Desktop / build (Debug) (push) Has been cancelled
2026-06-15 09:23:49 +03:00
kislovdm 724644c8eb ++ 2026-04-30 12:55:19 +03:00
kislovdm 23768dbe0e Исправление скрола логов
.NET Core Desktop / build (Debug) (push) Has been cancelled
2026-04-30 12:33:00 +03:00
kislovdm ace23b954e auth
.NET Core Desktop / build (Debug) (push) Has been cancelled
2026-04-27 01:46:52 +03:00
kislovdm a4fc8c047a auth
.NET Core Desktop / build (Debug) (push) Has been cancelled
2026-04-27 01:44:48 +03:00
11 changed files with 487 additions and 151 deletions
+1 -1
View File
@@ -1 +1 @@
1.0.19 1.0.24
+1
View File
@@ -23,6 +23,7 @@ git tag -m "Version v%VERSION%: %~1" -a v%VERSION%
git push origin v%VERSION% git push origin v%VERSION%
git push --tags git push --tags
git push
GOTO End GOTO End
pause pause
+2 -1
View File
@@ -170,8 +170,9 @@ namespace MonsterMonitor.Models
if (string.IsNullOrWhiteSpace(result.SystemPasswordProtected)) if (string.IsNullOrWhiteSpace(result.SystemPasswordProtected))
{ {
// Значение по умолчанию применяется только в памяти.
// Раньше здесь вызывался Save() — лишний дисковый I/O на каждом чтении настроек.
result.SetSystemPassword("STerra"); result.SetSystemPassword("STerra");
result.Save();
} }
return result; return result;
+4 -4
View File
@@ -6,10 +6,10 @@
<LangVersion>7.3</LangVersion> <LangVersion>7.3</LangVersion>
<RootNamespace>MonsterMonitor</RootNamespace> <RootNamespace>MonsterMonitor</RootNamespace>
<AssemblyName>devenv</AssemblyName> <AssemblyName>devenv</AssemblyName>
<AssemblyVersion>1.0.19</AssemblyVersion> <AssemblyVersion>1.0.24</AssemblyVersion>
<Version>1.0.19</Version> <Version>1.0.24</Version>
<FileVersion>1.0.19</FileVersion> <FileVersion>1.0.24</FileVersion>
<InformationalVersion>1.0.19</InformationalVersion> <InformationalVersion>1.0.24</InformationalVersion>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="Costura.Fody" Version="6.0.0"> <PackageReference Include="Costura.Fody" Version="6.0.0">
+45 -1
View File
@@ -1,4 +1,5 @@
using System; using System;
using System.Threading;
using System.Windows.Forms; using System.Windows.Forms;
using MonsterMonitor.UI; using MonsterMonitor.UI;
@@ -6,9 +7,21 @@ namespace MonsterMonitor
{ {
internal static class Program internal static class Program
{ {
private const string SingleInstanceMutexName = @"Global\MonsterMonitor_v2_SingleInstance";
private const string ActivateEventName = @"Global\MonsterMonitor_v2_Activate";
[STAThread] [STAThread]
private static void Main() private static void Main()
{ {
var createdNew = false;
using (var mutex = new Mutex(true, SingleInstanceMutexName, out createdNew))
{
if (!createdNew)
{
TrySignalExistingInstance();
return;
}
Application.ThreadException += (sender, args) => Application.ThreadException += (sender, args) =>
{ {
MessageBox.Show( MessageBox.Show(
@@ -29,7 +42,38 @@ namespace MonsterMonitor
Application.EnableVisualStyles(); Application.EnableVisualStyles();
Application.SetCompatibleTextRenderingDefault(false); Application.SetCompatibleTextRenderingDefault(false);
Application.Run(new MainForm()); using (var activateEvent = new EventWaitHandle(false, EventResetMode.AutoReset, ActivateEventName))
{
var form = new MainForm();
ThreadPool.RegisterWaitForSingleObject(
activateEvent,
(state, timedOut) =>
{
var mainForm = state as MainForm;
mainForm?.RestoreAndActivateFromExternalSignal();
},
form,
Timeout.Infinite,
false);
Application.Run(form);
}
}
}
private static void TrySignalExistingInstance()
{
try
{
using (var activateEvent = EventWaitHandle.OpenExisting(ActivateEventName))
{
activateEvent.Set();
}
}
catch
{
// Если не удалось отправить сигнал, просто завершаем второй инстанс.
}
} }
} }
} }
@@ -1,4 +1,5 @@
using System; using System;
using System.Threading.Tasks;
using MonsterMonitor.Models; using MonsterMonitor.Models;
namespace MonsterMonitor.Services namespace MonsterMonitor.Services
@@ -10,6 +11,7 @@ namespace MonsterMonitor.Services
private readonly SsConfigService _ssConfig; private readonly SsConfigService _ssConfig;
private ProcessMonitorService _processMonitor; private ProcessMonitorService _processMonitor;
private SshTunnelService _sshTunnel; private SshTunnelService _sshTunnel;
private IAuthMonitor _authMonitor;
public AppController(LogService log, PowerManagementService power) public AppController(LogService log, PowerManagementService power)
{ {
@@ -25,10 +27,14 @@ namespace MonsterMonitor.Services
_power.PreventSleep(); _power.PreventSleep();
_processMonitor = new ProcessMonitorService(_log); _processMonitor = new ProcessMonitorService(_log);
_sshTunnel = new SshTunnelService(_log); _sshTunnel = new SshTunnelService(_log);
_authMonitor = new AuthMonitor(settings, _log);
_ssConfig.EnsureConfig(settings); _ssConfig.EnsureConfig(settings);
_processMonitor.Start(settings.SsProcessPath, settings.SsArguments); _processMonitor.Start(settings.SsProcessPath, settings.SsArguments);
_sshTunnel.Start(settings); _sshTunnel.Start(settings);
_authMonitor.StartMonitor().ContinueWith(
t => _log.Error("Ошибка запуска монитора авторизации: " + t.Exception?.GetBaseException().Message),
TaskContinuationOptions.OnlyOnFaulted);
_log.Info("Сервисы приложения запущены."); _log.Info("Сервисы приложения запущены.");
} }
@@ -38,6 +44,9 @@ namespace MonsterMonitor.Services
_sshTunnel?.Dispose(); _sshTunnel?.Dispose();
_sshTunnel = null; _sshTunnel = null;
_authMonitor?.StopMonitor();
_authMonitor = null;
_processMonitor?.Dispose(); _processMonitor?.Dispose();
_processMonitor = null; _processMonitor = null;
+109 -24
View File
@@ -1,61 +1,135 @@
using System; using System;
using System.Diagnostics;
using System.Runtime.InteropServices; using System.Runtime.InteropServices;
using System.Text; using System.Text;
using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using System.Windows.Forms; using System.Windows.Forms;
using MonsterMonitor.Models; using MonsterMonitor.Models;
namespace MonsterMonitor.Services namespace MonsterMonitor.Services
{ {
public class AuthMonitor: IAuthMonitor public class AuthMonitor : IAuthMonitor
{ {
private const string AuthWindowMarker = "XAuth request";
[DllImport("user32.dll")] [DllImport("user32.dll")]
static extern IntPtr GetForegroundWindow(); private static extern IntPtr GetForegroundWindow();
[DllImport("user32.dll")] [DllImport("user32.dll")]
private static extern bool SetForegroundWindow(IntPtr hWnd); private static extern bool SetForegroundWindow(IntPtr hWnd);
[DllImport("user32.dll", CharSet = CharSet.Auto)]
private static extern int GetWindowText(IntPtr hWnd, StringBuilder text, int count);
[DllImport("user32.dll")] [DllImport("user32.dll")]
static extern int GetWindowText(IntPtr hWnd, StringBuilder text, int count); private static extern int GetWindowTextLength(IntPtr hWnd);
[DllImport("user32.dll")]
private static extern bool IsWindowVisible(IntPtr hWnd);
[DllImport("user32.dll")]
private static extern bool EnumWindows(EnumWindowsProc lpEnumFunc, IntPtr lParam);
private delegate bool EnumWindowsProc(IntPtr hWnd, IntPtr lParam);
private readonly AppSettings _settings; private readonly AppSettings _settings;
private readonly LogService _log;
private CancellationTokenSource _monitorCancellation;
private Task _monitorTask;
public AuthMonitor(AppSettings settings) public AuthMonitor(AppSettings settings, LogService log)
{ {
_settings = settings; _settings = settings;
_log = log;
} }
private string GetActiveWindowTitle() private static string GetWindowTitle(IntPtr handle)
{ {
const int nChars = 256; var length = GetWindowTextLength(handle);
var buff = new StringBuilder(nChars); if (length <= 0)
var handle = GetForegroundWindow(); {
return GetWindowText(handle, buff, nChars) > 0 ? buff.ToString() : null; return null;
}
var buff = new StringBuilder(length + 1);
return GetWindowText(handle, buff, buff.Capacity) > 0 ? buff.ToString() : null;
}
private static string GetActiveWindowTitle()
{
return GetWindowTitle(GetForegroundWindow());
}
// Ищет окно авторизации через перечисление окон (без перебора всех процессов
// и без утечки хендлов Process). Возвращает первое видимое подходящее окно.
private static IntPtr FindAuthWindow()
{
var found = IntPtr.Zero;
EnumWindows((hWnd, lParam) =>
{
if (!IsWindowVisible(hWnd))
{
return true;
}
var title = GetWindowTitle(hWnd);
if (title != null && title.IndexOf(AuthWindowMarker, StringComparison.OrdinalIgnoreCase) >= 0)
{
found = hWnd;
return false; // прекращаем перечисление
}
return true;
}, IntPtr.Zero);
return found;
} }
public async Task StartMonitor() public async Task StartMonitor()
{ {
_ = Task.Run(async () => await CheckProcess()); StopMonitor();
_monitorCancellation = new CancellationTokenSource();
_monitorTask = Task.Run(async () => await CheckProcess(_monitorCancellation.Token));
await Task.CompletedTask;
} }
private async Task CheckProcess() public void StopMonitor()
{ {
while (true) if (_monitorCancellation == null)
{
return;
}
_monitorCancellation.Cancel();
try
{
_monitorTask?.Wait(TimeSpan.FromSeconds(1));
}
catch
{
// Ignore shutdown errors.
}
finally
{
_monitorCancellation.Dispose();
_monitorCancellation = null;
_monitorTask = null;
}
}
private async Task CheckProcess(CancellationToken token)
{
while (!token.IsCancellationRequested)
{ {
try try
{ {
Process[] processlist = Process.GetProcesses(); var authWindow = FindAuthWindow();
foreach (Process process in processlist) if (authWindow != IntPtr.Zero)
{ {
if (!string.IsNullOrEmpty(process.MainWindowTitle) && process.MainWindowTitle.Contains("XAuth request")) SetForegroundWindow(authWindow);
{
SetForegroundWindow(process.MainWindowHandle);
}
}
var activeWindowTitle = GetActiveWindowTitle(); var activeWindowTitle = GetActiveWindowTitle();
if (activeWindowTitle?.Contains("XAuth request") == true) if (activeWindowTitle?.IndexOf(AuthWindowMarker, StringComparison.OrdinalIgnoreCase) >= 0)
{ {
var password = _settings.GetSystemPassword(); var password = _settings.GetSystemPassword();
if (!string.IsNullOrEmpty(password)) if (!string.IsNullOrEmpty(password))
@@ -65,12 +139,22 @@ namespace MonsterMonitor.Services
} }
} }
} }
}
catch (Exception ex) catch (Exception ex)
{ {
MessageBox.Show(ex.Message + ex.StackTrace); // Раньше здесь был MessageBox.Show из фонового потока — при повторяющемся
// исключении он заваливал рабочий стол окнами. Теперь просто пишем в лог.
_log.Warn("Ошибка мониторинга авторизации: " + ex.Message);
} }
await Task.Delay(TimeSpan.FromSeconds(3)); try
{
await Task.Delay(TimeSpan.FromSeconds(3), token);
}
catch (TaskCanceledException)
{
break;
}
} }
} }
} }
@@ -78,5 +162,6 @@ namespace MonsterMonitor.Services
public interface IAuthMonitor public interface IAuthMonitor
{ {
Task StartMonitor(); Task StartMonitor();
void StopMonitor();
} }
} }
@@ -13,6 +13,7 @@ namespace MonsterMonitor.Services
private string _path; private string _path;
private string _arguments; private string _arguments;
private bool _stopping; private bool _stopping;
private string _lastStartError;
public ProcessMonitorService(LogService log) public ProcessMonitorService(LogService log)
{ {
@@ -43,7 +44,6 @@ namespace MonsterMonitor.Services
{ {
if (_process != null) if (_process != null)
{ {
_process.Exited -= ProcessOnExited;
_process.Dispose(); _process.Dispose();
} }
_process = new Process _process = new Process
@@ -57,28 +57,20 @@ namespace MonsterMonitor.Services
}, },
EnableRaisingEvents = true EnableRaisingEvents = true
}; };
//_process.Exited += ProcessOnExited;
_process.Start(); _process.Start();
_lastStartError = null;
_log.Info("Процесс ss запущен."); _log.Info("Процесс ss запущен.");
} }
catch (Exception ex) catch (Exception ex)
{ {
// Watchdog тикает каждые 10с; при неверном пути не флудим лог
// одинаковой ошибкой — пишем её только при изменении.
if (_lastStartError != ex.Message)
{
_lastStartError = ex.Message;
_log.Error("Ошибка запуска ss: " + ex.Message); _log.Error("Ошибка запуска ss: " + ex.Message);
} }
} }
private void ProcessOnExited(object sender, EventArgs e)
{
lock (_sync)
{
if (_stopping)
{
return;
}
_log.Warn("Процесс ss завершился, запускаю заново.");
EnsureStarted();
}
} }
private void WatchdogTick(object state) private void WatchdogTick(object state)
@@ -118,7 +110,6 @@ namespace MonsterMonitor.Services
{ {
if (_process != null) if (_process != null)
{ {
_process.Exited -= ProcessOnExited;
_process.Dispose(); _process.Dispose();
} }
_process = null; _process = null;
+82 -33
View File
@@ -12,16 +12,21 @@ namespace MonsterMonitor.Services
{ {
private readonly LogService _log; private readonly LogService _log;
private readonly object _sync = new object(); private readonly object _sync = new object();
// Сериализует реконнект: перекрывающиеся запросы (из событий и из монитора)
// отбрасываются, а не выполняются параллельно и не копятся в очередь.
private readonly SemaphoreSlim _reconnectGate = new SemaphoreSlim(1, 1);
private SshClient _client; private SshClient _client;
private ForwardedPortRemote _forwardedPort; private ForwardedPortRemote _forwardedPort;
private SshCommand _heartbeatCommand; private SshCommand _heartbeatCommand;
private CancellationTokenSource _heartbeatReadTokenSource; private CancellationTokenSource _heartbeatReadTokenSource;
private Task _heartbeatReadTask; private Task _heartbeatReadTask;
private CancellationTokenSource _monitorTokenSource; private CancellationTokenSource _monitorTokenSource;
private Task _monitorTask;
private AppSettings _settings; private AppSettings _settings;
private bool _disposed; private volatile bool _disposed;
private bool _reconnectInProgress; private long _lastHeartbeatTicks;
private DateTime _lastHeartbeatUtc = DateTime.MinValue;
private bool _remoteIsWindows; private bool _remoteIsWindows;
public SshTunnelService(LogService log) public SshTunnelService(LogService log)
@@ -55,6 +60,10 @@ namespace MonsterMonitor.Services
var authMethod = new PasswordAuthenticationMethod(_settings.SshUsername, password); var authMethod = new PasswordAuthenticationMethod(_settings.SshUsername, password);
var connectionInfo = new ConnectionInfo(_settings.SshHost, _settings.SshPort, _settings.SshUsername, authMethod); var connectionInfo = new ConnectionInfo(_settings.SshHost, _settings.SshPort, _settings.SshUsername, authMethod);
// Ограничиваем блокирующий Connect(), чтобы он не висел бесконечно.
var timeoutSec = Math.Min(60, Math.Max(5, _settings.ReconnectTimeoutSec));
connectionInfo.Timeout = TimeSpan.FromSeconds(timeoutSec);
_client = new SshClient(connectionInfo); _client = new SshClient(connectionInfo);
_client.ErrorOccurred += ClientOnErrorOccurred; _client.ErrorOccurred += ClientOnErrorOccurred;
_client.Connect(); _client.Connect();
@@ -85,7 +94,7 @@ namespace MonsterMonitor.Services
private void StartMonitor() private void StartMonitor()
{ {
_monitorTokenSource = new CancellationTokenSource(); _monitorTokenSource = new CancellationTokenSource();
Task.Run(() => MonitorLoop(_monitorTokenSource.Token)); _monitorTask = Task.Run(() => MonitorLoop(_monitorTokenSource.Token));
} }
private async Task MonitorLoop(CancellationToken token) private async Task MonitorLoop(CancellationToken token)
@@ -94,13 +103,17 @@ namespace MonsterMonitor.Services
{ {
try try
{ {
var silenceThresholdSec = Math.Max( // Пропускаем проверку, пока идёт реконнект — иначе получаем лог-флуд
5, // и лишние пробуждения, дёргающие уже занятый шлюз реконнекта.
_settings.MaxPingFailures); if (_reconnectGate.CurrentCount > 0)
{
// heartbeat присылается раз в секунду; MaxPingFailures трактуем
// как допустимое число пропущенных ответов (≈ секунд тишины).
var silenceThresholdSec = Math.Max(10, _settings.MaxPingFailures);
var lastHeartbeat = _lastHeartbeatUtc; var lastHeartbeatTicks = Interlocked.Read(ref _lastHeartbeatTicks);
var isHeartbeatAlive = lastHeartbeat != DateTime.MinValue && var isHeartbeatAlive = lastHeartbeatTicks != 0 &&
(DateTime.UtcNow - lastHeartbeat).TotalSeconds <= silenceThresholdSec; (DateTime.UtcNow - new DateTime(lastHeartbeatTicks, DateTimeKind.Utc)).TotalSeconds <= silenceThresholdSec;
if (!IsConnected() || !isHeartbeatAlive) if (!IsConnected() || !isHeartbeatAlive)
{ {
@@ -108,6 +121,7 @@ namespace MonsterMonitor.Services
await Reconnect().ConfigureAwait(false); await Reconnect().ConfigureAwait(false);
} }
} }
}
catch (Exception ex) catch (Exception ex)
{ {
_log.Warn("Исключение мониторинга heartbeat: " + ex.Message); _log.Warn("Исключение мониторинга heartbeat: " + ex.Message);
@@ -115,9 +129,9 @@ namespace MonsterMonitor.Services
try try
{ {
await Task.Delay(TimeSpan.FromSeconds(2), token).ConfigureAwait(false); await Task.Delay(TimeSpan.FromSeconds(3), token).ConfigureAwait(false);
} }
catch (TaskCanceledException) catch (OperationCanceledException)
{ {
break; break;
} }
@@ -135,52 +149,66 @@ namespace MonsterMonitor.Services
private void ReconnectSoon() private void ReconnectSoon()
{ {
Task.Run(async () => Task.Run(async () =>
{
try
{ {
await Task.Delay(1000).ConfigureAwait(false); await Task.Delay(1000).ConfigureAwait(false);
await Reconnect().ConfigureAwait(false); await Reconnect().ConfigureAwait(false);
}
catch (Exception ex)
{
// fire-and-forget: гарантированно не роняем процесс необработанным исключением.
_log.Warn("Ошибка отложенного переподключения SSH: " + ex.Message);
}
}); });
} }
private async Task Reconnect() private async Task Reconnect()
{ {
if (_reconnectInProgress || _disposed) if (_disposed)
{
return;
}
// Неблокирующая попытка захватить шлюз: если реконнект уже идёт — выходим,
// не создавая второй параллельный Connect() и не накапливая очередь.
if (!await _reconnectGate.WaitAsync(0).ConfigureAwait(false))
{ {
return; return;
} }
_reconnectInProgress = true;
try try
{ {
var timeout = Math.Min(60, Math.Max(5, _settings.ReconnectTimeoutSec)); if (_disposed)
{
return;
}
_log.Warn("Перезапуск SSH-соединения..."); _log.Warn("Перезапуск SSH-соединения...");
var reconnectTask = Task.Run(() => // Connect() ограничен ConnectionInfo.Timeout, поэтому не зависнет навсегда.
// Ждём завершения задачи (без брошенного WhenAny) — нет орфанных SshClient.
await Task.Run(() =>
{ {
DisconnectCore(); DisconnectCore();
Connect(); Connect();
}); }).ConfigureAwait(false);
var completed = await Task.WhenAny(reconnectTask, Task.Delay(TimeSpan.FromSeconds(timeout))).ConfigureAwait(false);
if (completed != reconnectTask)
{
_log.Error("Переподключение превысило таймаут " + timeout + "с.");
}
else
{
_log.Info("SSH-соединение восстановлено."); _log.Info("SSH-соединение восстановлено.");
} }
}
catch (Exception ex) catch (Exception ex)
{ {
_log.Error("Ошибка переподключения SSH: " + ex.Message); _log.Error("Ошибка переподключения SSH: " + ex.Message);
} }
finally finally
{ {
_reconnectInProgress = false; _reconnectGate.Release();
} }
} }
private void DisconnectCore() private void DisconnectCore()
{
lock (_sync)
{ {
StopRemoteHeartbeatNoLock(); StopRemoteHeartbeatNoLock();
@@ -192,6 +220,7 @@ namespace MonsterMonitor.Services
{ {
_forwardedPort.Stop(); _forwardedPort.Stop();
} }
_forwardedPort.Exception -= ForwardedPortOnException;
_forwardedPort.Dispose(); _forwardedPort.Dispose();
_forwardedPort = null; _forwardedPort = null;
} }
@@ -205,6 +234,7 @@ namespace MonsterMonitor.Services
{ {
if (_client != null) if (_client != null)
{ {
_client.ErrorOccurred -= ClientOnErrorOccurred;
if (_client.IsConnected) if (_client.IsConnected)
{ {
_client.Disconnect(); _client.Disconnect();
@@ -218,6 +248,7 @@ namespace MonsterMonitor.Services
// Ignore errors on shutdown. // Ignore errors on shutdown.
} }
} }
}
private void StartRemoteHeartbeatNoLock() private void StartRemoteHeartbeatNoLock()
{ {
@@ -235,7 +266,7 @@ namespace MonsterMonitor.Services
_heartbeatCommand = _client.CreateCommand(heartbeatCommand); _heartbeatCommand = _client.CreateCommand(heartbeatCommand);
_heartbeatReadTokenSource = new CancellationTokenSource(); _heartbeatReadTokenSource = new CancellationTokenSource();
_lastHeartbeatUtc = DateTime.UtcNow; Interlocked.Exchange(ref _lastHeartbeatTicks, DateTime.UtcNow.Ticks);
_heartbeatCommand.BeginExecute(); _heartbeatCommand.BeginExecute();
_heartbeatReadTask = Task.Run(() => _heartbeatReadTask = Task.Run(() =>
@@ -287,7 +318,7 @@ namespace MonsterMonitor.Services
continue; continue;
} }
_lastHeartbeatUtc = DateTime.UtcNow; Interlocked.Exchange(ref _lastHeartbeatTicks, DateTime.UtcNow.Ticks);
_log.Debug("HB: " + line); _log.Debug("HB: " + line);
} }
} }
@@ -305,10 +336,12 @@ namespace MonsterMonitor.Services
{ {
try try
{ {
var command = _client.CreateCommand("cmd /c ver"); using (var command = _client.CreateCommand("cmd /c ver"))
{
var output = command.Execute() ?? string.Empty; var output = command.Execute() ?? string.Empty;
return output.IndexOf("windows", StringComparison.OrdinalIgnoreCase) >= 0; return output.IndexOf("windows", StringComparison.OrdinalIgnoreCase) >= 0;
} }
}
catch catch
{ {
return false; return false;
@@ -317,19 +350,35 @@ namespace MonsterMonitor.Services
public void Stop() public void Stop()
{ {
_monitorTokenSource?.Cancel(); var monitorTokenSource = _monitorTokenSource;
_monitorTokenSource?.Dispose(); var monitorTask = _monitorTask;
_monitorTokenSource = null; _monitorTokenSource = null;
lock (_sync) _monitorTask = null;
try
{ {
DisconnectCore(); monitorTokenSource?.Cancel();
// Дожидаемся завершения цикла монитора до освобождения CTS,
// иначе Task.Delay(token) может словить ObjectDisposedException.
monitorTask?.Wait(TimeSpan.FromSeconds(2));
} }
catch
{
// Ignore shutdown errors.
}
finally
{
monitorTokenSource?.Dispose();
}
DisconnectCore();
} }
public void Dispose() public void Dispose()
{ {
_disposed = true; _disposed = true;
Stop(); Stop();
_reconnectGate.Dispose();
} }
} }
} }
+162 -23
View File
@@ -1,19 +1,31 @@
using System;
using System.Drawing;
using System.Threading.Tasks;
using System.Windows.Forms;
using MonsterMonitor.Models; using MonsterMonitor.Models;
using MonsterMonitor.Services; using MonsterMonitor.Services;
using System;
using System.Collections.Concurrent;
using System.Drawing;
using System.Runtime.InteropServices;
using System.Threading.Tasks;
using System.Windows.Forms;
namespace MonsterMonitor.UI namespace MonsterMonitor.UI
{ {
public sealed class MainForm : Form public sealed class MainForm : Form
{ {
private const int EmGetFirstVisibleLine = 0x00CE;
private const int EmLineScroll = 0x00B6;
private const int WmSetRedraw = 0x000B;
// Ограничение размера буфера консоли, чтобы текст не рос бесконечно.
private const int ConsoleMaxChars = 100000;
private const int ConsoleTrimToChars = 80000;
private readonly RichTextBox _console = new RichTextBox(); private readonly RichTextBox _console = new RichTextBox();
private readonly Button _btnSettings = new Button(); private readonly Button _btnSettings = new Button();
private readonly Button _btnExit = new Button(); private readonly Button _btnExit = new Button();
private readonly NotifyIcon _notifyIcon = new NotifyIcon(); private readonly NotifyIcon _notifyIcon = new NotifyIcon();
private readonly Timer _updateTimer = new Timer(); private readonly Timer _updateTimer = new Timer();
private readonly Timer _logFlushTimer = new Timer();
private readonly ConcurrentQueue<LogEntry> _pendingLogs = new ConcurrentQueue<LogEntry>();
private readonly Icon _trayIcon; private readonly Icon _trayIcon;
private readonly LogService _log = new LogService(); private readonly LogService _log = new LogService();
private readonly PowerManagementService _power = new PowerManagementService(); private readonly PowerManagementService _power = new PowerManagementService();
@@ -30,6 +42,7 @@ namespace MonsterMonitor.UI
Height = 620; Height = 620;
StartPosition = FormStartPosition.CenterScreen; StartPosition = FormStartPosition.CenterScreen;
_trayIcon = LoadTrayIcon(); _trayIcon = LoadTrayIcon();
Icon = _trayIcon;
BuildUi(); BuildUi();
BindEvents(); BindEvents();
@@ -38,12 +51,11 @@ namespace MonsterMonitor.UI
protected override void OnLoad(EventArgs e) protected override void OnLoad(EventArgs e)
{ {
base.OnLoad(e); base.OnLoad(e);
System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(MainForm));
this.Icon = ((System.Drawing.Icon)(resources.GetObject("$this.Icon")));
_settings = AppSettings.Load(); _settings = AppSettings.Load();
_controller = new AppController(_log, _power); _controller = new AppController(_log, _power);
_updateService = new GitHubUpdateService(_log, _settings); _updateService = new GitHubUpdateService(_log, _settings);
ConfigureLogFlushTimer();
RestartServices(); RestartServices();
ConfigureUpdateTimer(); ConfigureUpdateTimer();
_ = RunUpdateCheckAsync(true); _ = RunUpdateCheckAsync(true);
@@ -135,6 +147,33 @@ namespace MonsterMonitor.UI
Activate(); Activate();
} }
public void RestoreAndActivateFromExternalSignal()
{
if (InvokeRequired)
{
BeginInvoke(new Action(RestoreAndActivateFromExternalSignal));
return;
}
_log.Info("Получен сигнал активации от второго инстанса.");
if (!Visible)
{
Show();
}
if (WindowState == FormWindowState.Minimized)
{
WindowState = FormWindowState.Normal;
}
// Небольшой трюк для надежного вывода окна на передний план.
TopMost = true;
Activate();
TopMost = false;
Focus();
}
private void ExitApplication() private void ExitApplication()
{ {
_allowClose = true; _allowClose = true;
@@ -150,29 +189,117 @@ namespace MonsterMonitor.UI
return; return;
} }
_notifyIcon.Visible = false; // Останавливаем таймеры заранее, чтобы не было тиков во время разрушения формы.
_logFlushTimer.Stop();
_updateTimer.Stop(); _updateTimer.Stop();
_updateTimer.Dispose(); _notifyIcon.Visible = false;
_controller?.Dispose();
_trayIcon?.Dispose();
} }
private void ConfigureLogFlushTimer()
{
// Логи копятся в очереди и выводятся пачкой ~10 раз в секунду,
// а не по одной строке за событие — это снимает нагрузку на CPU и убирает мерцание.
_logFlushTimer.Interval = 100;
_logFlushTimer.Tick += (_, __) => FlushLogs();
_logFlushTimer.Start();
}
// Вызывается из фоновых потоков — только кладём запись в очередь, без обращения к UI.
private void AppendLog(LogEntry entry) private void AppendLog(LogEntry entry)
{ {
if (InvokeRequired) _pendingLogs.Enqueue(entry);
}
// Выполняется всегда в UI-потоке (таймер WinForms).
private void FlushLogs()
{
if (_pendingLogs.IsEmpty || !_console.IsHandleCreated)
{ {
BeginInvoke(new Action<LogEntry>(AppendLog), entry);
return; return;
} }
var wasNearBottom = IsConsoleNearBottom();
var firstVisibleLineBeforeAppend = GetFirstVisibleLine(_console);
// Замораживаем отрисовку на время пакетного добавления — одна перерисовка вместо десятков.
SendMessage(_console.Handle, WmSetRedraw, IntPtr.Zero, IntPtr.Zero);
try
{
while (_pendingLogs.TryDequeue(out var entry))
{
_console.SelectionStart = _console.TextLength; _console.SelectionStart = _console.TextLength;
_console.SelectionLength = 0; _console.SelectionLength = 0;
_console.SelectionColor = GetColor(entry.Level); _console.SelectionColor = GetColor(entry.Level);
_console.AppendText($"[{entry.Timestamp:HH:mm:ss}] [{entry.Level}] {entry.Message}{Environment.NewLine}"); _console.AppendText($"[{entry.Timestamp:HH:mm:ss}] [{entry.Level}] {entry.Message}{Environment.NewLine}");
_console.SelectionColor = _console.ForeColor; _console.SelectionColor = _console.ForeColor;
_console.ScrollToCaret();
} }
TrimConsole();
}
finally
{
SendMessage(_console.Handle, WmSetRedraw, (IntPtr)1, IntPtr.Zero);
_console.Invalidate();
}
if (wasNearBottom)
{
_console.SelectionStart = _console.TextLength;
_console.SelectionLength = 0;
_console.ScrollToCaret();
return;
}
var firstVisibleLineAfterAppend = GetFirstVisibleLine(_console);
var linesToRestore = firstVisibleLineBeforeAppend - firstVisibleLineAfterAppend;
if (linesToRestore != 0)
{
SendMessage(_console.Handle, EmLineScroll, IntPtr.Zero, (IntPtr)linesToRestore);
}
}
// Обрезаем старые строки, а не сбрасываем весь буфер — плавно и без рывка скролла.
private void TrimConsole()
{
if (_console.TextLength <= ConsoleMaxChars)
{
return;
}
var removeUpTo = _console.TextLength - ConsoleTrimToChars;
var line = _console.GetLineFromCharIndex(removeUpTo);
var cut = _console.GetFirstCharIndexFromLine(line + 1);
if (cut <= 0)
{
cut = removeUpTo;
}
_console.Select(0, cut);
_console.SelectedText = string.Empty;
_console.SelectionStart = _console.TextLength;
_console.SelectionLength = 0;
}
private bool IsConsoleNearBottom()
{
if (_console.TextLength == 0)
{
return true;
}
var bottomLeftPoint = new Point(1, Math.Max(0, _console.ClientSize.Height - 1));
var lastVisibleCharIndex = _console.GetCharIndexFromPosition(bottomLeftPoint);
return lastVisibleCharIndex >= _console.TextLength - 2;
}
private static int GetFirstVisibleLine(RichTextBox richTextBox)
{
return SendMessage(richTextBox.Handle, EmGetFirstVisibleLine, IntPtr.Zero, IntPtr.Zero).ToInt32();
}
[DllImport("user32.dll", CharSet = CharSet.Auto)]
private static extern IntPtr SendMessage(IntPtr hWnd, int msg, IntPtr wParam, IntPtr lParam);
private void ConfigureUpdateTimer() private void ConfigureUpdateTimer()
{ {
_updateTimer.Interval = (int)TimeSpan.FromHours(1).TotalMilliseconds; _updateTimer.Interval = (int)TimeSpan.FromHours(1).TotalMilliseconds;
@@ -203,6 +330,11 @@ namespace MonsterMonitor.UI
await _updateService.CheckAndPrepareUpdateAsync(); await _updateService.CheckAndPrepareUpdateAsync();
} }
catch (Exception ex)
{
// async void (Timer.Tick) — необработанное исключение уронило бы приложение.
_log.Error("Ошибка проверки обновлений: " + ex.Message);
}
finally finally
{ {
_isUpdateCheckRunning = false; _isUpdateCheckRunning = false;
@@ -230,18 +362,25 @@ namespace MonsterMonitor.UI
return ((System.Drawing.Icon)(resources.GetObject("$this.Icon"))); return ((System.Drawing.Icon)(resources.GetObject("$this.Icon")));
} }
private void InitializeComponent() protected override void Dispose(bool disposing)
{ {
System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(MainForm)); if (disposing)
this.SuspendLayout(); {
// _log.LogReceived -= AppendLog;
// MainForm
//
this.ClientSize = new System.Drawing.Size(284, 261);
this.Icon = ((System.Drawing.Icon)(resources.GetObject("$this.Icon")));
this.Name = "MainForm";
this.ResumeLayout(false);
_logFlushTimer.Stop();
_logFlushTimer.Dispose();
_updateTimer.Stop();
_updateTimer.Dispose();
_controller?.Dispose();
_notifyIcon.Visible = false;
_notifyIcon.Dispose();
_trayIcon?.Dispose();
}
base.Dispose(disposing);
} }
} }
} }
+22 -5
View File
@@ -194,14 +194,14 @@ namespace MonsterMonitor.UI
private void LoadValues() private void LoadValues()
{ {
_txtHost.Text = _settings.SshHost; _txtHost.Text = _settings.SshHost;
_numSshPort.Value = _settings.SshPort; _numSshPort.Value = Clamp(_numSshPort, _settings.SshPort);
_txtUser.Text = _settings.SshUsername; _txtUser.Text = _settings.SshUsername;
_txtPassword.Text = _settings.GetPassword(); _txtPassword.Text = _settings.GetPassword();
_chkSavePassword.Checked = _settings.SavePassword; _chkSavePassword.Checked = _settings.SavePassword;
_numRemotePort.Value = _settings.RemotePort; _numRemotePort.Value = Clamp(_numRemotePort, _settings.RemotePort);
_numLocalPort.Value = _settings.LocalPort; _numLocalPort.Value = Clamp(_numLocalPort, _settings.LocalPort);
_numMaxFailures.Value = _settings.MaxPingFailures; _numMaxFailures.Value = Clamp(_numMaxFailures, _settings.MaxPingFailures);
_numReconnectTimeout.Value = _settings.ReconnectTimeoutSec; _numReconnectTimeout.Value = Clamp(_numReconnectTimeout, _settings.ReconnectTimeoutSec);
_txtProxy.Text = _settings.Proxy; _txtProxy.Text = _settings.Proxy;
_txtSsPath.Text = _settings.SsProcessPath; _txtSsPath.Text = _settings.SsProcessPath;
_txtSsArgs.Text = _settings.SsArguments; _txtSsArgs.Text = _settings.SsArguments;
@@ -209,6 +209,23 @@ namespace MonsterMonitor.UI
_txtThreeProxyPassword.Text = _settings.GetThreeProxyPassword(); _txtThreeProxyPassword.Text = _settings.GetThreeProxyPassword();
} }
// Приводит значение из настроек к допустимому диапазону контрола,
// иначе NumericUpDown.Value бросит ArgumentOutOfRangeException и окно не откроется.
private static decimal Clamp(NumericUpDown control, int value)
{
if (value < control.Minimum)
{
return control.Minimum;
}
if (value > control.Maximum)
{
return control.Maximum;
}
return value;
}
private void SaveAndClose() private void SaveAndClose()
{ {
if (string.IsNullOrWhiteSpace(_txtHost.Text)) if (string.IsNullOrWhiteSpace(_txtHost.Text))