Убрана настройка замены времени за день - заменяем всегда

.semver.txt

@@ -1 +1 @@
-1.0.34
+1.0.36

README.md

@@ -12,12 +12,12 @@
  - Путь до репо (Режим Mercurial) - путь до папки, в которую клонируются исходники.
  - Логин Jira - Логин в Jira (от этого пользователя будем выполнять запросы и вносить время).
  - Пароль Jira - шифруется через DPAPI.
- - Mercurial Name (Режим Mercurial) - обязателен к указанию для режима Mercurial - имя пользователя Mercurial, от которого проходят коммиты.
+ - Mercurial Name (Режим Mercurial) - обязателен к указанию для режима Mercurial - имя пользователя Mercurial, от которого проходят коммиты (именно UserName, не E-Mail).
  - Округление времени - Для красоты распределения времени тут устанавливается округление. По умолчанию - 15 минут, получим время 1:15, 0:30 итд. Остаток нераспределенного времени будет внесен в самую долгую задачу или же если это невозможно - количество рабочего времени будет увеличено или уменьшено.
  - JQL (Режим Jira) - можно задать свой JQL для поиска задач. Возможные замены: %USER% - Логин Jira, %DATE% дата на которую формируем список. Значнеие по умолчанию: status changed by '%USER%' during ("%DATE%","%DATE%")
+ - Задача "учёта времени" - задача, куда будет списываться по 30 минут в день на "затраты на учет времени". Должна содержать знак '-'.
  - Время запуска - время автоматического запуска бота. Если была установлена галочка "тестовый прогон" - она будет снята.
  - Добавлять описание (Режим Mercurial) - добавлять ли в описание CommitMessage, если не установлено - добавляются стандартные фразы программистов (типа "написание кода").
- - Задача "учёта времени" - задача, куда будет списываться по 30 минут в день на "затраты на учет времени". Должна содержать знак '-'.
 
 # Скачать
 Скачать актуальную версию можно тут: https://github.com/monster1025/JiraTimeBot/releases/latest

src/JiraTimeBot/JiraIntegration/JiraApi.cs

@@ -62,7 +62,38 @@ namespace JiraTimeBot.JiraIntegration
             }
         }
 
-        public void SetTodayWorklog(List<TaskTimeItem> taskTimeItems, Settings settings, DateTime? date = null, bool dummy = false, bool addCommentsToWorklog = false)
+        public List<Issue> GetWorkloggedIssuesByDate(Settings settings, DateTime? date = null, CancellationToken cancellationToken = default(CancellationToken))
+        {
+            date = date.GetValueOrDefault(DateTime.Now.Date);
+            var jql = "issueFunction in workLogged(\"on %DATE% by '%USER%'\")";
+            return GetIssuesByJQL(jql, settings, date, cancellationToken);
+        }
+
+        private void RemoveWorklogsAddedByUser(List<TaskTimeItem> taskTimeItems, Settings settings, DateTime? date = null,  bool dummy = false, CancellationToken cancellationToken = default(CancellationToken))
+        {
+            var alreadyLoggedToday = GetWorkloggedIssuesByDate(settings, date);
+            foreach (var issue in alreadyLoggedToday)
+            {
+                if (!taskTimeItems.Any(f => f.Branch.Equals(issue.Key.Value, StringComparison.InvariantCulture)))
+                {
+                    var workLogs = issue.GetWorklogsAsync(cancellationToken).Result;
+                    var userWorklogs = workLogs.Where(w =>
+                        w.CreateDate.GetValueOrDefault().Date == date && w.Author.Equals(settings.JiraUserName,
+                            StringComparison.InvariantCultureIgnoreCase)).ToList();
+                    foreach (var userWorklog in userWorklogs)
+                    {
+                        _log.Trace($"Удаляю добавленный руками WorkLog для задачи {issue.Key.Value}: {userWorklog.TimeSpent}, {userWorklog.Comment}.");
+
+                        if (!dummy)
+                        {
+                            issue.DeleteWorklogAsync(userWorklog, token: cancellationToken);
+                        }
+                    }
+                }
+            }
+        }
+
+        public void SetTodayWorklog(List<TaskTimeItem> taskTimeItems, Settings settings, DateTime? date = null, bool dummy = false, bool addCommentsToWorklog = false, CancellationToken cancellationToken = default(CancellationToken))
         {
             var jira = Jira.CreateRestClient(settings.JiraUrl, settings.JiraUserName, settings.JiraPassword);
 
@@ -72,6 +103,9 @@ namespace JiraTimeBot.JiraIntegration
             }
             date = date.Value.Date;
 
+            //Удаляем добавленные вручную пользователем данные.
+            RemoveWorklogsAddedByUser(taskTimeItems, settings, date, dummy, cancellationToken);
+
             foreach (TaskTimeItem taskTimeItem in taskTimeItems)
             {
                 Issue issue = null;

src/JiraTimeBot/JiraIntegration/JiraCommitEmulator.cs

@@ -37,6 +37,7 @@ namespace JiraTimeBot.JiraIntegration
                 var comments = issue.GetCommentsAsync(cancellationToken).Result?.ToList() ?? new List<Comment>();
 
                 var user = settings.JiraUserName;
+                //user = "Zoya.Aleksandridi";
                 var userComments = comments.Where(f => f.Author.Equals(user, StringComparison.InvariantCultureIgnoreCase)).ToList();
                 _log.Trace($"Получены комментарии по задаче {issue.Key} ({issue.Type?.Name}): {userComments.Count}.");
 

src/JiraTimeBot/Job.cs

@@ -71,7 +71,7 @@ namespace JiraTimeBot
                     continue;
                 }
 
-                tasksProcessor.Process(date, taskTimes, settings, dummyMode);
+                tasksProcessor.Process(date, taskTimes, settings, dummyMode, cancellationToken);
 
                 _log.Info("Готово.");
                 return;

src/JiraTimeBot/Properties/AssemblyInfo.cs

@@ -1,31 +1,31 @@
-using System.Reflection;                         
-using System.Runtime.InteropServices;                         
-// General Information about an assembly is controlled through the following                         
-// set of attributes. Change these attribute values to modify the information                         
-// associated with an assembly.                         
-[assembly: AssemblyTitle("JiraTimeBot")]                         
-[assembly: AssemblyDescription("")]                         
-[assembly: AssemblyConfiguration("")]                         
-[assembly: AssemblyCompany("")]                         
-[assembly: AssemblyProduct("JiraTimeBot")]                         
-[assembly: AssemblyCopyright("Copyright © 2019")]                         
-[assembly: AssemblyTrademark("")]                         
-[assembly: AssemblyCulture("")]                         
-// Setting ComVisible to false makes the types in this assembly not visible                         
-// to COM components.  If you need to access a type in this assembly from                         
-// COM, set the ComVisible attribute to true on that type.                         
-[assembly: ComVisible(false)]                         
-// The following GUID is for the ID of the typelib if this project is exposed to COM                         
-[assembly: Guid("f3b89316-c38c-4ce6-9d88-0b1373cfba1a")]                         
-// Version information for an assembly consists of the following four values:                         
-//                         
-//      Major Version                         
-//      Minor Version                         
-//      Build Number                         
-//      Revision                         
-//                         
-// You can specify all the values or you can default the Build and Revision Numbers                         
-// by using the '*' as shown below:                         
-[assembly: AssemblyVersion("1.0.34")] 
-[assembly: AssemblyFileVersion("1.0.34")] 
-[assembly: AssemblyInformationalVersion("1.0.34")] 
+using System.Reflection;                           
+using System.Runtime.InteropServices;                           
+// General Information about an assembly is controlled through the following                           
+// set of attributes. Change these attribute values to modify the information                           
+// associated with an assembly.                           
+[assembly: AssemblyTitle("JiraTimeBot")]                           
+[assembly: AssemblyDescription("")]                           
+[assembly: AssemblyConfiguration("")]                           
+[assembly: AssemblyCompany("")]                           
+[assembly: AssemblyProduct("JiraTimeBot")]                           
+[assembly: AssemblyCopyright("Copyright © 2019")]                           
+[assembly: AssemblyTrademark("")]                           
+[assembly: AssemblyCulture("")]                           
+// Setting ComVisible to false makes the types in this assembly not visible                           
+// to COM components.  If you need to access a type in this assembly from                           
+// COM, set the ComVisible attribute to true on that type.                           
+[assembly: ComVisible(false)]                           
+// The following GUID is for the ID of the typelib if this project is exposed to COM                           
+[assembly: Guid("f3b89316-c38c-4ce6-9d88-0b1373cfba1a")]                           
+// Version information for an assembly consists of the following four values:                           
+//                           
+//      Major Version                           
+//      Minor Version                           
+//      Build Number                           
+//      Revision                           
+//                           
+// You can specify all the values or you can default the Build and Revision Numbers                           
+// by using the '*' as shown below:                           
+[assembly: AssemblyVersion("1.0.36")] 
+[assembly: AssemblyFileVersion("1.0.36")] 
+[assembly: AssemblyInformationalVersion("1.0.36")] 

src/JiraTimeBot/TaskTime/TaskTimeByCommitsCalculator.cs

@@ -104,9 +104,21 @@ namespace JiraTimeBot.TaskTime
                 workTimeItems.First().Time += TimeSpan.FromMinutes(remainMinutes);
             }
 
+            PrintTotal(workTimeItems);
+
             return workTimeItems;
         }
 
+        private void PrintTotal(List<TaskTimeItem> workTimeItems)
+        {
+            var totalTime = TimeSpan.Zero;
+            foreach (var workTimeItem in workTimeItems)
+            {
+                totalTime += workTimeItem.Time;
+            }
+
+            _log.Trace($"Итоговое реально проставляемое время: {totalTime}");
+        }
 
 
         private decimal RoundTo(decimal value, decimal to = 15, bool up = true)

src/JiraTimeBot/TasksProcessors/ITasksProcessor.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Threading;
 using JiraTimeBot.Configuration;
 using JiraTimeBot.TaskTime.Objects;
 
@@ -7,6 +8,6 @@ namespace JiraTimeBot.TasksProcessors
 {
     interface ITasksProcessor
     {
-        void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode);
+        void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode, CancellationToken cancellationToken = default(CancellationToken));
     }
 }

src/JiraTimeBot/TasksProcessors/MeetingProcessor.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading;
 using JiraTimeBot.Configuration;
 using JiraTimeBot.JiraIntegration;
 using JiraTimeBot.TaskTime.Objects;
@@ -18,7 +19,7 @@ namespace JiraTimeBot.TasksProcessors
             _jiraApi = jiraApi;
         }
 
-        public void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode)
+        public void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode, CancellationToken cancellationToken = default(CancellationToken))
         {
             _log.Trace($"На реальную дату {date:dd.MM.yyyy} распределение по задачам:");
 

src/JiraTimeBot/TasksProcessors/WorkLogTasksProcessor.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Threading;
 using JiraTimeBot.Configuration;
 using JiraTimeBot.JiraIntegration;
 using JiraTimeBot.TaskTime.Objects;
@@ -17,7 +18,7 @@ namespace JiraTimeBot.TasksProcessors
             _jiraApi = jiraApi;
         }
 
-        public void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode)
+        public void Process(DateTime date, List<TaskTimeItem> taskTimes, Settings settings, bool dummyMode, CancellationToken cancellationToken = default(CancellationToken))
         {
             _log.Trace($"На реальную дату {date:dd.MM.yyyy} распределение по задачам:");
             foreach (var taskTime in taskTimes)
@@ -25,7 +26,7 @@ namespace JiraTimeBot.TasksProcessors
                 _log.Trace($"- {taskTime.Branch} (коммитов {taskTime.Commits}): {taskTime.Time}");
             }
 
-            _jiraApi.SetTodayWorklog(taskTimes, settings, dummy: dummyMode, addCommentsToWorklog: settings.AddCommentsToWorklog);
+            _jiraApi.SetTodayWorklog(taskTimes, settings, dummy: dummyMode, addCommentsToWorklog: settings.AddCommentsToWorklog, cancellationToken: cancellationToken);
         }
     }
 }

src/JiraTimeBot/UI/frmSettings.Designer.cs

@@ -153,7 +153,7 @@
             // chkAddComments
             // 
             this.chkAddComments.AutoSize = true;
-            this.chkAddComments.Location = new System.Drawing.Point(56, 277);
+            this.chkAddComments.Location = new System.Drawing.Point(65, 277);
             this.chkAddComments.Name = "chkAddComments";
             this.chkAddComments.Size = new System.Drawing.Size(133, 17);
             this.chkAddComments.TabIndex = 31;
@@ -162,7 +162,7 @@
             // 
             // btnSave
             // 
-            this.btnSave.Location = new System.Drawing.Point(72, 310);
+            this.btnSave.Location = new System.Drawing.Point(86, 300);
             this.btnSave.Name = "btnSave";
             this.btnSave.Size = new System.Drawing.Size(75, 23);
             this.btnSave.TabIndex = 32;
@@ -227,7 +227,7 @@
             // chkAutostart
             // 
             this.chkAutostart.AutoSize = true;
-            this.chkAutostart.Location = new System.Drawing.Point(56, 254);
+            this.chkAutostart.Location = new System.Drawing.Point(65, 254);
             this.chkAutostart.Name = "chkAutostart";
             this.chkAutostart.Size = new System.Drawing.Size(96, 17);
             this.chkAutostart.TabIndex = 40;
@@ -238,7 +238,7 @@
             // 
             this.AutoScaleDimensions = new System.Drawing.SizeF(6F, 13F);
             this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Font;
-            this.ClientSize = new System.Drawing.Size(243, 342);
+            this.ClientSize = new System.Drawing.Size(243, 334);
             this.Controls.Add(this.chkAutostart);
             this.Controls.Add(this.label8);
             this.Controls.Add(this.txtTimeControlTask);

src/JiraTimeBot/UI/frmSettings.cs

@@ -33,7 +33,6 @@ namespace JiraTimeBot.UI
             txtMercurialEmail.Text = settings.MercurialAuthorEmail;
             txtRepoPath.Text = settings.RepositoryPath;
             actTime.Text = settings.ActivationTime.ToString("hh\\:mm\\:ss");
-            //txtDummyMode.Checked = settings.DummyMode;
             chkAddComments.Checked = settings.AddCommentsToWorklog;
             txtRoundTo.Text = settings.RountToMinutes.ToString();
             cboWorkType.SelectedIndex = (int) settings.WorkType;
@@ -56,14 +55,13 @@ namespace JiraTimeBot.UI
                 MercurialAuthorEmail = txtMercurialEmail.Text,
                 ActivationTime = TimeSpan.Parse(actTime.Text),
                 RepositoryPath = txtRepoPath.Text,
-                //DummyMode = txtDummyMode.Checked,
                 AddCommentsToWorklog = chkAddComments.Checked,
                 RountToMinutes = roundTo,
                 WorkType = (WorkType) cboWorkType.SelectedIndex,
                 JiraQuery = txtJQL.Text,
-                TimeControlTask = txtTimeControlTask.Text
+                TimeControlTask = txtTimeControlTask.Text,
             };
-            
+
             //LockUnlock(false);
 
             return settings;